Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: tests/language/stack_trace_test.dart

Issue 23691024: If a rethrow is encountered in the catch block, then its handler must be marked that it needs stack… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/vm/intermediate_language.h ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Dart test program for testing throw statement 4 // Dart test program for testing throw statement
5 5
6 import "package:expect/expect.dart"; 6 import "package:expect/expect.dart";
7 7
8 class MyException { 8 class MyException {
9 const MyException(String message) : message_ = message; 9 const MyException(String message) : message_ = message;
10 final String message_; 10 final String message_;
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 } 76 }
77 77
78 } 78 }
79 79
80 class StackTraceTest { 80 class StackTraceTest {
81 static testMain() { 81 static testMain() {
82 Expect.equals(850, Helper.f1(1)); 82 Expect.equals(850, Helper.f1(1));
83 } 83 }
84 } 84 }
85 85
86
87 // Test that the full stack trace is generated for rethrow.
88 class RethrowStacktraceTest {
89 var config = 0;
90
91 a() {
92 throw "Progy";
93 }
94
95 b() {
96 a();
97 }
98
99 c() {
100 if (config == 0) {
101 try {
102 b();
103 } catch (e) {
104 rethrow;
105 }
106 } else {
107 try {
108 b();
109 } catch (e, s) {
110 rethrow;
111 }
112 }
113 }
114
115 d() {
116 c();
117 }
118
119 testBoth() {
120 int prev_len = -1;
121 for (config = 0; config < 2; config++) {
122 try {
123 d();
124 } catch (e, s) {
125 if (prev_len < 0) {
126 prev_len = s.toString().length;
127 } else {
128 // Check both stacktraces have same length.
129 Expect.equals(prev_len, s.toString().length);
Ivan Posva 2013/08/31 00:06:23 How about just checking that a() is in the stacktr
srdjan 2013/08/31 00:18:06 renamed a to issue12940 and checking for it.
130 }
131 }
132 }
133 }
134
135 static testMain() {
136 var test = new RethrowStacktraceTest();
137 test.testBoth();
138 }
139 }
140
141
86 main() { 142 main() {
87 StackTraceTest.testMain(); 143 StackTraceTest.testMain();
144 RethrowStacktraceTest.testMain();
88 } 145 }
OLDNEW
« runtime/vm/intermediate_language.h ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698