Issue 23658048: Revert "dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23658048: Revert "dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks." (Closed)

Created:
7 years, 3 months ago by Bill Hesse

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks." This reverts commit r27475. BUG=dartbug.com/1016 Committed: https://code.google.com/p/dart/source/detail?r=27481

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -288 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/file_patch.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file_system_entity_patch.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/bin/file_win.cc	View	1 chunk	+7 lines, -37 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/directory.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/io/file.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	2 chunks	+22 lines, -3 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	3 chunks	+1 line, -64 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/standalone/io/file_error_test.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View	2 chunks	+11 lines, -0 lines	0 comments	Download
D	tests/standalone/io/resolve_symbolic_links_test.dart	View	1 chunk	+0 lines, -147 lines	0 comments	Download

Total messages: 2 (0 generated)

Bill Hesse

The CL causes a crash on Debug Windows that is not reproducible on my desktop.

7 years, 3 months ago (2013-09-13 14:51:02 UTC) #1

lgtm