Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: sdk/lib/io/file_impl.dart

Issue 23658048: Revert "dart:io | Change File.fullPath to FileSystemEntity.resolveSymbolicLinks." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/file.dart ('k') | sdk/lib/io/file_system_entity.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file_impl.dart
diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart
index 1ec4b111abe1bb482a8b5ee2ebd2d98bd67e0bdb..86acf7774915cd4fedd11a2ec97d3f55245b5e8a 100644
--- a/sdk/lib/io/file_impl.dart
+++ b/sdk/lib/io/file_impl.dart
@@ -204,7 +204,7 @@ const int _CREATE_REQUEST = 1;
const int _DELETE_REQUEST = 2;
const int _RENAME_REQUEST = 3;
const int _OPEN_REQUEST = 4;
-const int _RESOLVE_SYMBOLIC_LINKS_REQUEST = 5;
+const int _FULL_PATH_REQUEST = 5;
const int _CLOSE_REQUEST = 6;
const int _POSITION_REQUEST = 7;
const int _SET_POSITION_REQUEST = 8;
@@ -446,9 +446,28 @@ class _File extends FileSystemEntity implements File {
return new _RandomAccessFile(id, "");
}
- Future<String> fullPath() => resolveSymbolicLinks();
+ Future<String> fullPath() {
+ _ensureFileService();
+ List request = new List(2);
+ request[0] = _FULL_PATH_REQUEST;
+ request[1] = path;
+ return _fileService.call(request).then((response) {
+ if (_isErrorResponse(response)) {
+ throw _exceptionFromResponse(response,
+ "Cannot retrieve full path",
+ path);
+ }
+ return response;
+ });
+ }
- String fullPathSync() => resolveSymbolicLinksSync();
+ external static _fullPath(String path);
+
+ String fullPathSync() {
+ var result = _fullPath(path);
+ throwIfError(result, "Cannot retrieve full path", path);
+ return result;
+ }
Stream<List<int>> openRead([int start, int end]) {
return new _FileStream(path, start, end);
« no previous file with comments | « sdk/lib/io/file.dart ('k') | sdk/lib/io/file_system_entity.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698