Remove processing of dart code, summary.dart, simplified info.dart

Remove processing of dart code, summary.dart, simplified info.dart
(note: this builds on top of the previous CL)

R=jmesserly@google.com, terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26832

[terry, 2013-08-28 21:41:51]

LGTM, using transforms really makes the world much cleaner and and not a huge
chunk of code.

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
File pkg/polymer/lib/src/analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
pkg/polymer/lib/src/analyzer.dart:27: Document document, Messages messages) {
I we plan of only running in pub deploy should Messages change to the Transform
logger?

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
File pkg/polymer/lib/src/css_analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
pkg/polymer/lib/src/css_analyzer.dart:120: Set<StyleSheet> _dependencies(var
inputUrl, var libraryInfo, {Set<StyleSheet> seen}) {
line length > 80?

[Jennifer Messerly, 2013-08-28 22:10:25]

LGTM

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
File pkg/polymer/lib/src/analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
pkg/polymer/lib/src/analyzer.dart:27: Document document, Messages messages) {
On 2013/08/28 21:41:52, terry wrote:
> I we plan of only running in pub deploy should Messages change to the
Transform
> logger?

+1 ... please kill Messages :)

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
File pkg/polymer/lib/src/css_analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
pkg/polymer/lib/src/css_analyzer.dart:120: Set<StyleSheet> _dependencies(var
inputUrl, var libraryInfo, {Set<StyleSheet> seen}) {
also no need for "var" on these parameters.

Signed,
The Department of Redundancy Department

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/test/run.sh
File pkg/polymer/test/run.sh (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/test/run.sh#newco...
pkg/polymer/test/run.sh:73: echo Analyzing analyzer for warnings or type errors
do we need to analyze the analyzing analyzer too?

[Siggi Cherem (dart-lang), 2013-08-29 00:34:15]

thx

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
File pkg/polymer/lib/src/analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/analyzer....
pkg/polymer/lib/src/analyzer.dart:27: Document document, Messages messages) {
On 2013/08/28 22:10:25, John Messerly wrote:
> On 2013/08/28 21:41:52, terry wrote:
> > I we plan of only running in pub deploy should Messages change to the
> Transform
> > logger?
> 
> +1 ... please kill Messages :)

I'll keep it in mind, but I wont do it just yet. What happens is that the
analyzer code is separate from the deploy code. So far I was not planning on
using barback to run the analzyer, but we could switch to that in the future.
Meanwhile, we need to keep messages. I'll make it simpler though =).

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
File pkg/polymer/lib/src/css_analyzer.dart (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/lib/src/css_analy...
pkg/polymer/lib/src/css_analyzer.dart:120: Set<StyleSheet> _dependencies(var
inputUrl, var libraryInfo, {Set<StyleSheet> seen}) {
On 2013/08/28 22:10:25, John Messerly wrote:
> also no need for "var" on these parameters.
> 
> Signed,
> The Department of Redundancy Department

funny, I was just copying the old code structure and didn't event see it. 

Done

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/test/run.sh
File pkg/polymer/test/run.sh (right):

https://codereview.chromium.org/23658002/diff/1/pkg/polymer/test/run.sh#newco...
pkg/polymer/test/run.sh:73: echo Analyzing analyzer for warnings or type errors
On 2013/08/28 22:10:25, John Messerly wrote:
> do we need to analyze the analyzing analyzer too?

:-)

mmm... actually it might not be a bad idea. When the analyzer was reporting
transitive warnings from other packages, it used to show warnings from
analyzer_experimental, ... maybe we should add a test for it in the repo =)

[Siggi Cherem (dart-lang), 2013-08-29 00:34:32]

Committed patchset #2 manually as r26832 (presubmit successful).