Remove processing of dart code, summary.dart, simplified info.dart

pkg/polymer/lib/src/css_analyzer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Portion of the analyzer dealing with CSS sources. */
 library polymer.src.css_analyzer;
 
 import 'package:csslib/parser.dart' as css;
 import 'package:csslib/visitor.dart';
 import 'package:html5lib/dom.dart';
@@ skipping 29 matching lines @@
   _AnalyzerCss(this.info, this._pseudoElements,
                this._messages, this._warningsAsErrors);
 
   /**
    * Run the analyzer on every file that is a style sheet or any component that
    * has a style tag.
    */
   void process(SourceFile file) {
     var fileInfo = info[file.path];
     if (file.isStyleSheet || fileInfo.styleSheets.length > 0) {
-      var styleSheets = processVars(fileInfo);
+      var styleSheets = processVars(fileInfo.inputUrl, fileInfo);
 
       // Add to list of all style sheets analyzed.
       allStyleSheets.addAll(styleSheets);
     }
 
     // Process any components.
     for (var component in fileInfo.declaredComponents) {
-      var all = processVars(component);
+      var all = processVars(fileInfo.inputUrl, component);
 
       // Add to list of all style sheets analyzed.
       allStyleSheets.addAll(all);
     }
 
     processCustomPseudoElements();
   }
 
   void normalize() {
     // Remove all var definitions for all style sheets analyzed.
     for (var tree in allStyleSheets) new _RemoveVarDefinitions().visitTree(tree);
   }
 
-  List<StyleSheet> processVars(var libraryInfo) {
+  List<StyleSheet> processVars(var inputUrl, var libraryInfo) {
     // Get list of all stylesheet(s) dependencies referenced from this file.
-    var styleSheets = _dependencies(libraryInfo).toList();
+    var styleSheets = _dependencies(inputUrl, libraryInfo).toList();
 
     var errors = [];
     css.analyze(styleSheets, errors: errors, options:
       [_warningsAsErrors ? '--warnings_as_errors' : '', 'memory']);
 
     // Print errors as warnings.
     for (var e in errors) {
       _messages.warning(e.message, e.span);
     }
 
@@ skipping 25 matching lines @@
     for (var tree in allStyleSheets) {
       polyFiller.visitTree(tree);
     }
   }
 
   /**
    * Given a component or file check if any stylesheets referenced.  If so then
    * return a list of all referenced stylesheet dependencies (@imports or <link
    * rel="stylesheet" ..>).
    */
-  Set<StyleSheet> _dependencies(var libraryInfo, {Set<StyleSheet> seen}) {
+  Set<StyleSheet> _dependencies(var inputUrl, var libraryInfo, {Set<StyleSheet> seen}) {

[terry, 2013/08/28 21:41:52]

line length > 80?

[Jennifer Messerly, 2013/08/28 22:10:25]

also no need for "var" on these parameters.

Signed,
The Department of Redundancy Department

[Siggi Cherem (dart-lang), 2013/08/29 00:34:15]

funny, I was just copying the old code structure and didn't event see it. 

Done

     if (seen == null) seen = new Set();
 
-    // Used to resolve all pathing information.
-    var inputUrl = libraryInfo is FileInfo
-        ? libraryInfo.inputUrl
-        : (libraryInfo as ComponentInfo).declaringFile.inputUrl;
-
     for (var styleSheet in libraryInfo.styleSheets) {
       if (!seen.contains(styleSheet)) {
         // TODO(terry): VM uses expandos to implement hashes.  Currently, it's a
         //              linear (not constant) time cost (see dartbug.com/5746).
         //              If this bug isn't fixed and performance show's this a
         //              a problem we'll need to implement our own hashCode or
         //              use a different key for better perf.
         // Add the stylesheet.
         seen.add(styleSheet);
 
         // Any other imports in this stylesheet?
         var urlInfos = findImportsInStyleSheet(styleSheet, inputUrl, _messages);
 
         // Process other imports in this stylesheets.
         for (var importSS in urlInfos) {
           var importInfo = info[importSS.resolvedPath];
           if (importInfo != null) {
             // Add all known stylesheets processed.
             seen.addAll(importInfo.styleSheets);
             // Find dependencies for stylesheet referenced with a
             // @import
             for (var ss in importInfo.styleSheets) {
               var urls = findImportsInStyleSheet(ss, inputUrl, _messages);
               for (var url in urls) {
-                _dependencies(info[url.resolvedPath], seen: seen);
+                var fileInfo = info[url.resolvedPath];
+                _dependencies(fileInfo.inputUrl, fileInfo, seen: seen);
               }
             }
           }
         }
       }
     }
 
     return seen;
   }
 }
@@ skipping 328 matching lines @@
 
         // Find all imports return list of @imports in this style tag.
         var urlInfos = findImportsInStyleSheet(styleSheet,
             _inputUrl, _messages);
         imports.addAll(urlInfos);
       }
     }
     super.visitElement(node);
   }
 }