Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 23647013: Dart helper methods to support the Dart REPL (Closed)

Created:
7 years, 3 months ago by Jacob
Modified:
7 years, 3 months ago
Reviewers:
vsm, siva
CC:
hausner, devoncarew, reviews_dartlang.org
Visibility:
Public.

Description

Dart helper methods to support the Dart REPL BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27436

Patch Set 1 #

Patch Set 2 : ready for review #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M tools/dom/src/native_DOMImplementation.dart View 1 2 2 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jacob
Companion CL for https://codereview.chromium.org/23710032/ that defines the utility method to build up the dart expression ...
7 years, 3 months ago (2013-09-12 00:39:31 UTC) #1
vsm
lgtm https://codereview.chromium.org/23647013/diff/2001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/23647013/diff/2001/tools/dom/src/native_DOMImplementation.dart#newcode18 tools/dom/src/native_DOMImplementation.dart:18: if (member.endsWith('=')) { I don't think this is ...
7 years, 3 months ago (2013-09-12 01:01:21 UTC) #2
Jacob
https://codereview.chromium.org/23647013/diff/2001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/23647013/diff/2001/tools/dom/src/native_DOMImplementation.dart#newcode18 tools/dom/src/native_DOMImplementation.dart:18: if (member.endsWith('=')) { On 2013/09/12 01:01:21, vsm wrote: > ...
7 years, 3 months ago (2013-09-12 17:02:37 UTC) #3
Jacob
Committed patchset #3 manually as r27436 (presubmit successful).
7 years, 3 months ago (2013-09-12 17:03:25 UTC) #4
siva
7 years, 3 months ago (2013-09-12 21:26:59 UTC) #5
Message was sent while issue was closed.
This results in a diff in the reference generated dart files stored in the
repository (output of go.sh).
I have uploaded a CL
https://codereview.chromium.org/23533055/
to fix that.

Powered by Google App Engine
This is Rietveld 408576698