Issue 23646003: Fixing createFragment on IE9 Table elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23646003: Fixing createFragment on IE9 Table elements (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing createFragment on IE9 Table elements Basically IE9 does not support innerHTML on table elements, so need to go one level up and wrap everything in a <table> tag. Another issue is that IE9 does not support creating body elements or the matches call when the element is not in the document, updated the test to account for these. BUG=12830 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26806

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+45 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	tests/html/element_test.dart	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTableElement.darttemplate	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTableRowElement.darttemplate	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTableSectionElement.darttemplate	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 3 months ago (2013-08-28 18:03:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26806 (presubmit successful).

Expand Messages | Collapse Messages