Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 23646003: Fixing createFragment on IE9 Table elements (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index eb831c073f31928cb771e64492cb23d547e5829e..b17920267ad6db18f4cc55430eac9027498b5753 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -22335,6 +22335,22 @@ class TableElement extends HtmlElement native "HTMLTableElement" {
@JSName('createTBody')
TableSectionElement _nativeCreateTBody() native;
+ DocumentFragment createFragment(String html,
+ {NodeValidator validator, NodeTreeSanitizer treeSanitizer}) {
+ if (Range.supportsCreateContextualFragment) {
+ return super.createFragment(
+ html, validator: validator, treeSanitizer: treeSanitizer);
+ }
+ // IE9 workaround which does not support innerHTML on Table elements.
+ var contextualHtml = '<table>$html</table>';
+ var table = new Element.html(contextualHtml, validator: validator,
+ treeSanitizer: treeSanitizer);
+ var fragment = new DocumentFragment();
+ fragment.nodes.addAll(table.nodes);
+
+ return fragment;
+ }
+
// To suppress missing implicit constructor warnings.
factory TableElement._() { throw new UnsupportedError("Not supported"); }
@@ -22425,6 +22441,21 @@ class TableRowElement extends HtmlElement native "HTMLTableRowElement" {
TableCellElement insertCell(int index) => _insertCell(index);
+ DocumentFragment createFragment(String html,
+ {NodeValidator validator, NodeTreeSanitizer treeSanitizer}) {
+ if (Range.supportsCreateContextualFragment) {
+ return super.createFragment(
+ html, validator: validator, treeSanitizer: treeSanitizer);
+ }
+ // IE9 workaround which does not support innerHTML on Table elements.
+ var fragment = new DocumentFragment();
+ var section = new TableElement().createFragment(
+ html, validator: validator, treeSanitizer: treeSanitizer).nodes.single;
+ var row = section.nodes.single;
+ fragment.nodes.addAll(row.nodes);
+ return fragment;
+ }
+
// To suppress missing implicit constructor warnings.
factory TableRowElement._() { throw new UnsupportedError("Not supported"); }
@@ -22473,6 +22504,20 @@ class TableSectionElement extends HtmlElement native "HTMLTableSectionElement" {
TableRowElement insertRow(int index) => _insertRow(index);
+ DocumentFragment createFragment(String html,
+ {NodeValidator validator, NodeTreeSanitizer treeSanitizer}) {
+ if (Range.supportsCreateContextualFragment) {
+ return super.createFragment(
+ html, validator: validator, treeSanitizer: treeSanitizer);
+ }
+ // IE9 workaround which does not support innerHTML on Table elements.
+ var fragment = new DocumentFragment();
+ var section = new TableElement().createFragment(
+ html, validator: validator, treeSanitizer: treeSanitizer).nodes.single;
+ fragment.nodes.addAll(section.nodes);
+ return fragment;
+ }
+
// To suppress missing implicit constructor warnings.
factory TableSectionElement._() { throw new UnsupportedError("Not supported"); }
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698