Issue 23641006: Enable type inference when using mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23641006: Enable type inference when using mirrors. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable type inference when using mirrors. This reapplies https://codereview.chromium.org//22640009. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26922

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 chunk	+3 lines, -0 lines	1 comment	Download
A	tests/compiler/dart2js_extra/mirror_type_inference_field_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js_extra/mirror_type_inference_function_test.dart	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

Committed patchset #1 manually as r26922 (presubmit successful).

7 years, 3 months ago (2013-08-30 15:51:15 UTC) #3

ngeoffray

7 years, 3 months ago (2013-09-01 12:04:34 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23641006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/23641006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:298:
if (element.isField() && compiler.backend.isNeededForReflection(element)) {
After commit comments: this does not belong here, but should be covered by the
canBeUsedForGlobalOptimizations. I have a CL for fixing this.

Expand Messages | Collapse Messages