Issue 22640009: Enable type inference when using mirrors.

Issue 22640009: Enable type inference when using mirrors. (Closed)

Created:
7 years, 4 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable type inference when using mirrors. For potentially invoked functions, infer dynamic for all parameters. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26882

Patch Set 2 : Handle fields. #

Patch Set 3 : Update comment. #

Patch Set 5 : Move test to the backend. #

Patch Set 6 : Add explicit case for fields again. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2 3 4 5	1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js_extra/mirror_type_inference_field_test.dart	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
A	tests/compiler/dart2js_extra/mirror_type_inference_function_test.dart	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

As we discussed, let's put the runtime check that @MirrorsUsed is properly used prior to ...

7 years, 4 months ago (2013-08-15 15:40:38 UTC) #2

ahe

Nice! https://codereview.chromium.org/22640009/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/22640009/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode290 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:290: if (element.isField() && compiler.backend.isNeededForReflection(element)) { On 2013/08/15 15:40:38, ...

7 years, 4 months ago (2013-08-15 17:44:31 UTC) #3

karlklose

7 years, 3 months ago (2013-08-29 17:11:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r26882 (presubmit successful).

Expand Messages | Collapse Messages