Fix create symlink in windows by using an absolute path instead.

Fix create symlink in windows by using an absolute path instead.

Committed: https://code.google.com/p/dart/source/detail?r=27443

[Siggi Cherem (dart-lang), 2013-09-12 18:37:24]

tbr

[Siggi Cherem (dart-lang), 2013-09-12 18:37:52]

Committed patchset #1 manually as r27443 (presubmit successful).

[Jennifer Messerly, 2013-09-12 19:32:00]

https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
File pkg/polymer/lib/src/barback_runner.dart (right):

https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
pkg/polymer/lib/src/barback_runner.dart:243: var targetPath =
Platform.operatingSystem == 'windows'
is this a pathos bug or a dart:io bug?

(we shouldn't need platform specific checks in a pure-Dart library, IMO)

[Siggi Cherem (dart-lang), 2013-09-12 19:32:59]

On 2013/09/12 19:32:00, John Messerly wrote:
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> File pkg/polymer/lib/src/barback_runner.dart (right):
> 
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> pkg/polymer/lib/src/barback_runner.dart:243: var targetPath =
> Platform.operatingSystem == 'windows'
> is this a pathos bug or a dart:io bug?
> 
> (we shouldn't need platform specific checks in a pure-Dart library, IMO)

In dart:io, I filed https://code.google.com/p/dart/issues/detail?id=13279

[Jennifer Messerly, 2013-09-12 19:38:08]

https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
File pkg/polymer/lib/src/barback_runner.dart (right):

https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
pkg/polymer/lib/src/barback_runner.dart:243: var targetPath =
Platform.operatingSystem == 'windows'
On 2013/09/12 19:32:00, John Messerly wrote:
> is this a pathos bug or a dart:io bug?
> 
> (we shouldn't need platform specific checks in a pure-Dart library, IMO)

suggestion: remove the == 'windows' check and make the path absolute always.

[Siggi Cherem (dart-lang), 2013-09-12 19:42:35]

On 2013/09/12 19:38:08, John Messerly wrote:
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> File pkg/polymer/lib/src/barback_runner.dart (right):
> 
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> pkg/polymer/lib/src/barback_runner.dart:243: var targetPath =
> Platform.operatingSystem == 'windows'
> On 2013/09/12 19:32:00, John Messerly wrote:
> > is this a pathos bug or a dart:io bug?
> > 
> > (we shouldn't need platform specific checks in a pure-Dart library, IMO)
> 
> suggestion: remove the == 'windows' check and make the path absolute always.

yeah, I was debating about it. I sort-of like the relative symlinks enough to
keep them around, but I can be persuaded otherwise. This is not a super reason,
but a couple bug reports this past week had a zip file which included relative
symlinks, which magically work when you open them up =)

[Jennifer Messerly, 2013-09-12 19:53:57]

On 2013/09/12 19:42:35, Siggi Cherem (dart-lang) wrote:
> On 2013/09/12 19:38:08, John Messerly wrote:
> >
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> > File pkg/polymer/lib/src/barback_runner.dart (right):
> > 
> >
>
https://codereview.chromium.org/23621039/diff/1/pkg/polymer/lib/src/barback_r...
> > pkg/polymer/lib/src/barback_runner.dart:243: var targetPath =
> > Platform.operatingSystem == 'windows'
> > On 2013/09/12 19:32:00, John Messerly wrote:
> > > is this a pathos bug or a dart:io bug?
> > > 
> > > (we shouldn't need platform specific checks in a pure-Dart library, IMO)
> > 
> > suggestion: remove the == 'windows' check and make the path absolute always.
> 
> yeah, I was debating about it. I sort-of like the relative symlinks enough to
> keep them around, but I can be persuaded otherwise. This is not a super
reason,
> but a couple bug reports this past week had a zip file which included relative
> symlinks, which magically work when you open them up =)

ah, gotcha. that's neat