Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: pkg/polymer/lib/src/barback_runner.dart

Issue 23621039: Fix create symlink in windows by using an absolute path instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/lib/src/barback_runner.dart
diff --git a/pkg/polymer/lib/src/barback_runner.dart b/pkg/polymer/lib/src/barback_runner.dart
index e7a11af678172c6400fa011d5d6395fd81a16bc0..eaf637b27cc90d39aa60d3360bf2908a51de7cee 100644
--- a/pkg/polymer/lib/src/barback_runner.dart
+++ b/pkg/polymer/lib/src/barback_runner.dart
@@ -239,8 +239,10 @@ Future _addPackagesSymlinks(AssetSet assets, BarbackOptions options) {
if (firstDir == 'web' || (options.transformTests && firstDir == 'test')) {
var dir = path.join(options.outDir, path.dirname(id.path));
var linkPath = path.join(dir, 'packages');
- var targetPath = path.relative(outPackages, from: dir);
_deleteIfPresent(linkPath);
+ var targetPath = Platform.operatingSystem == 'windows'
Jennifer Messerly 2013/09/12 19:32:00 is this a pathos bug or a dart:io bug? (we should
Jennifer Messerly 2013/09/12 19:38:08 suggestion: remove the == 'windows' check and make
+ ? path.normalize(path.absolute(outPackages))
+ : path.normalize(path.relative(outPackages, from: dir));
new Link(linkPath).createSync(targetPath);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698