Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 236173002: Adds more arithmetic ops to arm64. (Closed)

Created:
6 years, 8 months ago by zra
Modified:
6 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds more arithmetic ops to arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35024

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -6 lines) Patch
M runtime/vm/assembler_arm64.h View 1 3 chunks +75 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 1 chunk +186 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/constants_arm64.h View 1 2 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 5 chunks +72 lines, -5 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 8 months ago (2014-04-11 23:32:07 UTC) #1
regis
LGTM
6 years, 8 months ago (2014-04-14 16:30:40 UTC) #2
zra
6 years, 8 months ago (2014-04-14 17:03:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698