Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 23609032: Add "function" as an argument to Dart_ActivationFrameInfo (Closed)

Created:
7 years, 3 months ago by Jacob
Modified:
7 years, 3 months ago
Reviewers:
hausner
CC:
vsm, reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add "function" as an argument to Dart_ActivationFrameInfo BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=27440

Patch Set 1 #

Total comments: 2

Patch Set 2 : PTAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M runtime/bin/dbg_message.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jacob
This is needed for CL https://codereview.chromium.org/23710032/
7 years, 3 months ago (2013-09-12 00:26:45 UTC) #1
hausner
Please add the parameter to the API function that replaces the deprecated Dart_ActivationFrameInfo. https://codereview.chromium.org/23609032/diff/1/runtime/include/dart_debugger_api.h File ...
7 years, 3 months ago (2013-09-12 00:32:19 UTC) #2
Jacob
https://codereview.chromium.org/23609032/diff/1/runtime/include/dart_debugger_api.h File runtime/include/dart_debugger_api.h (right): https://codereview.chromium.org/23609032/diff/1/runtime/include/dart_debugger_api.h#newcode414 runtime/include/dart_debugger_api.h:414: Dart_Handle* function, On 2013/09/12 00:32:19, hausner wrote: > Please ...
7 years, 3 months ago (2013-09-12 17:38:49 UTC) #3
hausner
LGTM. Thank you for updating the test!
7 years, 3 months ago (2013-09-12 17:43:02 UTC) #4
Jacob
7 years, 3 months ago (2013-09-12 17:45:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698