Fix ParameterMirror.toString and FunctionTypeMirror.toString.

VM: Make ParameterMirror.toString say it is a parameter mirror.
VM: Make FunctionTypeMirror.toString use the form (args) -> retval.
dart2js: Fix FunctionTypeMirror.toString's use of separators.

BUG=http://dartbug.com/13079
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27213

[ahe, 2013-09-05 20:43:39]

LGTM thanks!

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1509: s += sep;
I was really tired when I wrote this :-)

https://codereview.chromium.org/23601018/diff/9001/tests/lib/mirrors/typedef_...
File tests/lib/mirrors/typedef_test.dart (right):

https://codereview.chromium.org/23601018/diff/9001/tests/lib/mirrors/typedef_...
tests/lib/mirrors/typedef_test.dart:89: FunctionTypeMirror on
'${ft('(dart.core.int, dart.core.num)', 'dart.core.String')}'
Long line, store it in a variable named type as below.

https://codereview.chromium.org/23601018/diff/9001/tests/lib/mirrors/typedef_...
tests/lib/mirrors/typedef_test.dart:111: type = ft('(dart.core.int,
[dart.core.num, dart.core.num])', 'dart.core.String');
Long line.

https://codereview.chromium.org/23601018/diff/9001/tests/lib/mirrors/typedef_...
tests/lib/mirrors/typedef_test.dart:139: type = ft('(dart.core.int, {y:
dart.core.num, z: dart.core.num})', 'dart.core.String');
Long line.

[Michael Lippautz (Google), 2013-09-05 20:49:13]

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1509: s += sep;
On 2013/09/05 20:43:39, ahe wrote:
> I was really tired when I wrote this :-)

s += _arguments.map((e) => runtimeTypeToString(e)).join(", ") ?

[rmacnak, 2013-09-05 20:55:49]

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/23601018/diff/9001/sdk/lib/_internal/lib/js_m...
sdk/lib/_internal/lib/js_mirrors.dart:1509: s += sep;
On 2013/09/05 20:43:39, ahe wrote:
> I was really tired when I wrote this :-)

I always have to refer back to the implementation of do:separatedBy: to remember
how to do this correctly :)

[rmacnak, 2013-09-05 20:57:27]

Committed patchset #2 manually as r27213 (presubmit successful).