Issue 23599003: Fix read/write of binary assets in deploy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23599003: Fix read/write of binary assets in deploy (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 3 months ago

Reviewers:
terry, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix read/write of binary assets in deploy R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=26725

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	pkg/polymer/lib/deploy.dart	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/23599003/diff/1/pkg/polymer/lib/deploy.dart File pkg/polymer/lib/deploy.dart (left): https://codereview.chromium.org/23599003/diff/1/pkg/polymer/lib/deploy.dart#oldcode122 pkg/polymer/lib/deploy.dart:122: .then((content) => new File(filepath).writeAsStringSync(content))); turns out I was reading ...

7 years, 3 months ago (2013-08-27 16:54:28 UTC) #1

Siggi Cherem (dart-lang)

7 years, 3 months ago (2013-08-27 17:16:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26725 (presubmit successful).

Expand Messages | Collapse Messages