Fix read/write of binary assets in deploy

pkg/polymer/lib/deploy.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Temporary deploy command used to create a version of the app that can be
  * compiled with dart2js and deployed. This library should go away once `pub
  * deploy` can be configured to run barback transformers.
  *
  * From an application package you can run this program by calling dart with a
@@ skipping 100 matching lines @@
         filepath = path.join(outDir, id.path);
       } else if (id.path.startsWith('lib/')) {
         filepath = path.join(outDir, 'web', 'packages', id.package,
             id.path.substring(4));
       } else {
         // TODO(sigmund): do something about other assets?
         continue;
       }
 
       _ensureDir(path.dirname(filepath));
-      futures.add(asset.readAsString()
-        .then((content) => new File(filepath).writeAsStringSync(content)));

[Siggi Cherem (dart-lang), 2013/08/27 16:54:28]

turns out I was reading a .png file this way, yikes!

The change of the default utf8 encoder to be non-lenient helped detect this.

+      var writer = new File(filepath).openWrite();
+      futures.add(writer.addStream(asset.read()).then((_) => writer.close()));
     }
     return Future.wait(futures);
   }).then((_) {
     // Copy also all the files we didn't process
     var futures = [];
     for (var package in _ignoredPackages) {
       for (var relpath in _listDir(package, 'lib')) {
         var inpath = path.join(_packageDirs[package], relpath);
         var outpath = path.join(outDir, 'web', 'packages', package,
             relpath.substring(4));
@@ skipping 87 matching lines @@
     print(e.message);
     _showUsage(parser);
     return null;
   }
 }
 
 _showUsage(parser) {
   print('Usage: dart package:polymer/deploy.dart [options]');
   print(parser.getUsage());
 }