Issue 23594011: Loads some large Smis from the object pool on x64.

Issue 23594011: Loads some large Smis from the object pool on x64. (Closed)

Created:
7 years, 3 months ago by zra

Modified:
7 years, 2 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Loads some large Smis from the object pool on x64. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=27885

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	runtime/vm/assembler_x64.cc	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	runtime/vm/object_x64_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Getting started on moving large constants into the object pool.

7 years, 3 months ago (2013-09-24 21:11:06 UTC) #1

Florian Schneider

lgtm https://codereview.chromium.org/23594011/diff/5001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/23594011/diff/5001/runtime/vm/assembler_x64.cc#newcode2228 runtime/vm/assembler_x64.cc:2228: // TODO(zra, kmillikin): Move the use of large ...

7 years, 2 months ago (2013-09-25 14:13:28 UTC) #2

zra

Thanks! https://codereview.chromium.org/23594011/diff/5001/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://codereview.chromium.org/23594011/diff/5001/runtime/vm/assembler_x64.cc#newcode2228 runtime/vm/assembler_x64.cc:2228: // TODO(zra, kmillikin): Move the use of large ...

7 years, 2 months ago (2013-09-25 15:27:07 UTC) #3

zra

7 years, 2 months ago (2013-09-25 15:30:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27885 (presubmit successful).

Expand Messages | Collapse Messages