Loads some large Smis from the object pool on x64.

runtime/vm/assembler_x64.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/assembler.h"
 #include "vm/heap.h"
 #include "vm/memory_region.h"
@@ skipping 2207 matching lines @@
   }
   // If the call is patchable, do not reuse an existing entry since each
   // reference may be patched independently.
   object_pool_.Add(smi, Heap::kOld);
   patchable_pool_entries_.Add(patchable);
   return object_pool_.Length() - 1;
 }
 
 
 bool Assembler::CanLoadFromObjectPool(const Object& object) {
   // TODO(zra, kmillikin): Move the use of large Smis into the constant pool.

[Florian Schneider, 2013/09/25 14:13:28]

Update the TODO comment?

[zra, 2013/09/25 15:27:07]

Done.

   if (object.IsSmi()) {
-    return false;
+    // If the raw Smi does not fit into a 32-bit signed int, then we'll keep

[Florian Schneider, 2013/09/25 14:13:28]

s/Smi/smi

[zra, 2013/09/25 15:27:07]

Done.

+    // the raw value in the object pool.
+    return !Utils::IsInt(32, reinterpret_cast<int64_t>(object.raw()));
   }
   ASSERT(object.IsNotTemporaryScopedHandle());
   ASSERT(object.IsOld());
   return (Isolate::Current() != Dart::vm_isolate()) &&
          // Not in the VMHeap, OR is one of the VMHeap objects we put in every
          // object pool.
          // TODO(zra): Evaluate putting all VM heap objects into the pool.
          (!object.InVMHeap() || (object.raw() == Object::null()) ||
                                 (object.raw() == Bool::True().raw()) ||
                                 (object.raw() == Bool::False().raw()));
@@ skipping 638 matching lines @@
 
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64