Issue 23593002: Only emit members in mirror helper symbolsmap.

Issue 23593002: Only emit members in mirror helper symbolsmap. (Closed)

Created:
7 years, 3 months ago by zarah

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only emit members in mirror helper symbolsmap. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=26771

Patch Set 2 : Changed comment. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -44 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart	View	1	1 chunk	+17 lines, -26 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirror_renamer/mirror_renamer.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/lib/mirror_helper.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/mirror_helper_rename_test.dart	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	tests/compiler/dart2js/mirror_helper_test.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/23593002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/23593002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode184 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:184: // Build a sorted (by usage) list of ...

7 years, 3 months ago (2013-08-28 07:04:23 UTC) #2

zarah

Committed patchset #2 manually as r26771 (presubmit successful).

7 years, 3 months ago (2013-08-28 08:47:03 UTC) #3

zarah

7 years, 3 months ago (2013-08-28 10:18:14 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23593002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
(right):

https://codereview.chromium.org/23593002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:184: //
Build a sorted (by usage) list of local nodes that will be renamed to
On 2013/08/28 07:04:23, Johnni Winther wrote:
> "a sorted ... local nodes" -> "a list sorted by usage of local nodes"?

Done.

Expand Messages | Collapse Messages