Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: tests/compiler/dart2js/mirror_helper_rename_test.dart

Issue 23593002: Only emit members in mirror helper symbolsmap. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed comment. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/lib/mirror_helper.dart ('k') | tests/compiler/dart2js/mirror_helper_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirror_helper_rename_test.dart
diff --git a/tests/compiler/dart2js/mirror_helper_rename_test.dart b/tests/compiler/dart2js/mirror_helper_rename_test.dart
index 9e9df860efeb26edc3e3398c77480e3c780f6924..67f1a956312c237dcce2a5d66c041c9f079b3f4e 100644
--- a/tests/compiler/dart2js/mirror_helper_rename_test.dart
+++ b/tests/compiler/dart2js/mirror_helper_rename_test.dart
@@ -48,8 +48,6 @@ void testWithMirrorHelperLibrary({bool minify}) {
Expect.isFalse(null == backend.mirrorHelperLibrary);
Expect.isFalse(null == backend.mirrorHelperGetNameFunction);
- Expect.isTrue(symbols.containsValue(
- const SourceString(MirrorRenamer.MIRROR_HELPER_GET_NAME_FUNCTION)));
for (Node n in renames.keys) {
if (symbols.containsKey(renames[n])) {
@@ -69,10 +67,10 @@ void testWithMirrorHelperLibrary({bool minify}) {
if (minify) {
- Expect.equals(1, i.length);
+ Expect.equals(0, i.length);
} else {
- // Appears twice in code (defined & called) and twice in renames map.
- Expect.equals(4, i.length);
+ // Appears twice in code (defined & called).
+ Expect.equals(2, i.length);
}
String mapMatch = 'const<String,SourceString>';
« no previous file with comments | « sdk/lib/_internal/lib/mirror_helper.dart ('k') | tests/compiler/dart2js/mirror_helper_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698