Issue 235483002: Updating code_transformer's ResolverTransform to filter on Dart entry points in apply.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235483002: Updating code_transformer's ResolverTransform to filter on Dart entry points in apply. (Closed)

Created:
6 years, 8 months ago by blois

Modified:
6 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating code_transformer's ResolverTransform to allow filtering on Dart entry points in apply. This is to allow Angular's transformers to continue to filter the assets considered entry points based on whether they contain a main() rather than just the asset ID. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34985

Patch Set 1 : #

Total comments: 1

Patch Set 2 : CR change & nudge the version #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -15 lines)			Patch
M	pkg/code_transformers/lib/src/entry_point.dart	View		1 chunk	+16 lines, -8 lines	0 comments	Download
M	pkg/code_transformers/lib/src/resolvers.dart	View	1	3 chunks	+25 lines, -2 lines	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/test/resolver_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/235483002/diff/20001/pkg/code_transformers/lib/src/resolvers.dart File pkg/code_transformers/lib/src/resolvers.dart (right): https://codereview.chromium.org/235483002/diff/20001/pkg/code_transformers/lib/src/resolvers.dart#newcode54 pkg/code_transformers/lib/src/resolvers.dart:54: Future<bool> isPrimary(asset_or_id) { nit, I think we would ...

6 years, 8 months ago (2014-04-11 17:01:02 UTC) #2

blois

6 years, 8 months ago (2014-04-11 17:44:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34985 (presubmit successful).

Expand Messages | Collapse Messages