Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: pkg/code_transformers/lib/src/entry_point.dart

Issue 235483002: Updating code_transformer's ResolverTransform to filter on Dart entry points in apply. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: CR change & nudge the version Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/code_transformers/lib/src/resolvers.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 import 'dart:async'; 4 import 'dart:async';
5 5
6 import 'package:analyzer/analyzer.dart' as analyzer; 6 import 'package:analyzer/analyzer.dart' as analyzer;
7 import 'package:analyzer/src/generated/ast.dart'; 7 import 'package:analyzer/src/generated/ast.dart';
8 import 'package:barback/barback.dart'; 8 import 'package:barback/barback.dart';
9 9
10 /// Checks to see if the provided Asset is a Dart entry point. 10 /// Checks to see if the provided AssetId is a Dart file in a directory which
11 /// may contain entry points.
11 /// 12 ///
12 /// Assets are considered entry points if they are Dart files located in 13 /// Directories are considered entry points if they are Dart files located in
13 /// web/, test/, benchmark/ or example/ and have a main() function. 14 /// web/, test/, benchmark/ or example/.
15 bool isPossibleDartEntryId(AssetId id) {
16 if (id.extension != '.dart') return false;
17
18 return ['benchmark', 'example', 'test', 'web']
19 .any((dir) => id.path.startsWith("$dir/"));
20 }
21
22 /// Checks to see if the provided Asset is possibly a Dart entry point.
23 ///
24 /// Assets are considered entry points if they pass [isPossibleDartEntryId] and
25 /// have a main() method.
14 /// 26 ///
15 /// Because this only analyzes the primary asset this may return true for files 27 /// Because this only analyzes the primary asset this may return true for files
16 /// which are not dart entries if the file does not have a main() but does have 28 /// which are not dart entries if the file does not have a main() but does have
17 /// parts or exports. 29 /// parts or exports.
18 Future<bool> isPossibleDartEntry(Asset asset) { 30 Future<bool> isPossibleDartEntry(Asset asset) {
19 if (asset.id.extension != '.dart') return new Future.value(false); 31 if (!isPossibleDartEntryId(asset.id)) return new Future.value(false);
20 32
21 if (!['benchmark', 'example', 'test', 'web']
22 .any((dir) => asset.id.path.startsWith("$dir/"))) {
23 return new Future.value(false);
24 }
25 return asset.readAsString().then((contents) { 33 return asset.readAsString().then((contents) {
26 return _couldBeEntrypoint( 34 return _couldBeEntrypoint(
27 analyzer.parseCompilationUnit(contents, suppressErrors: true)); 35 analyzer.parseCompilationUnit(contents, suppressErrors: true));
28 }); 36 });
29 } 37 }
30 38
31 bool _couldBeEntrypoint(CompilationUnit compilationUnit) { 39 bool _couldBeEntrypoint(CompilationUnit compilationUnit) {
32 // Allow two or fewer arguments so that entrypoints intended for use with 40 // Allow two or fewer arguments so that entrypoints intended for use with
33 // [spawnUri] get counted. 41 // [spawnUri] get counted.
34 var hasMain = compilationUnit.declarations.any((node) => 42 var hasMain = compilationUnit.declarations.any((node) =>
35 node is FunctionDeclaration && 43 node is FunctionDeclaration &&
36 node.name.name == "main" && 44 node.name.name == "main" &&
37 node.functionExpression.parameters.parameters.length <= 2); 45 node.functionExpression.parameters.parameters.length <= 2);
38 46
39 if (hasMain) return true; 47 if (hasMain) return true;
40 48
41 // If it has an export or a part, assume the worst- that the main could be 49 // If it has an export or a part, assume the worst- that the main could be
42 // in there. 50 // in there.
43 // We avoid loading those since this can be run from isPrimaryAsset calls 51 // We avoid loading those since this can be run from isPrimaryAsset calls
44 // where we do not have access to other sources. 52 // where we do not have access to other sources.
45 return compilationUnit.directives.any((node) => 53 return compilationUnit.directives.any((node) =>
46 node is ExportDirective || node is PartDirective); 54 node is ExportDirective || node is PartDirective);
47 } 55 }
OLDNEW
« no previous file with comments | « no previous file | pkg/code_transformers/lib/src/resolvers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698