Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 235363005: Adds comparisons, labels, branches to arm64 (Closed)

Created:
6 years, 8 months ago by zra
Modified:
6 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds comparisons, labels, branches. Also adds compare-and-branch, test-and-branch, and unconditional branch with 26-bit offset instrucitons to the disassembler and simulator, but not to the assembler, yet, since they'll require a bit more work and this CL is getting big. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=34993

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+840 lines, -80 lines) Patch
M runtime/vm/assembler_arm64.h View 1 2 7 chunks +97 lines, -15 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 2 2 chunks +326 lines, -3 lines 0 comments Download
M runtime/vm/constants_arm64.h View 1 2 6 chunks +69 lines, -1 line 0 comments Download
M runtime/vm/disassembler_arm64.cc View 1 2 9 chunks +159 lines, -28 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 6 chunks +170 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
6 years, 8 months ago (2014-04-11 18:11:55 UTC) #1
regis
LGTM https://codereview.chromium.org/235363005/diff/20001/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/235363005/diff/20001/runtime/vm/assembler_arm64.h#newcode671 runtime/vm/assembler_arm64.h:671: const int32_t hiimm = ((imm & 0x1ffffc) >> ...
6 years, 8 months ago (2014-04-11 20:29:21 UTC) #2
zra
Thanks! https://codereview.chromium.org/235363005/diff/20001/runtime/vm/assembler_arm64.h File runtime/vm/assembler_arm64.h (right): https://codereview.chromium.org/235363005/diff/20001/runtime/vm/assembler_arm64.h#newcode671 runtime/vm/assembler_arm64.h:671: const int32_t hiimm = ((imm & 0x1ffffc) >> ...
6 years, 8 months ago (2014-04-11 20:39:58 UTC) #3
zra
6 years, 8 months ago (2014-04-11 20:40:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r34993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698