Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 23534050: Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling… (Closed)

Created:
7 years, 3 months ago by siva
Modified:
7 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single" 2. Fix templateloader to deal with nested 'if' conditions R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27270

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -84 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 60 chunks +60 lines, -60 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 18 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 2 chunks +16 lines, -1 line 0 comments Download
M tools/dom/scripts/templateloader.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
siva
7 years, 3 months ago (2013-09-04 23:19:28 UTC) #1
vsm
lgtm, but can you also run go.sh in dart/tools/dom/scripts and ensure the generated file changes ...
7 years, 3 months ago (2013-09-05 00:00:14 UTC) #2
siva
On 2013/09/05 00:00:14, vsm wrote: > lgtm, but can you also run go.sh in dart/tools/dom/scripts ...
7 years, 3 months ago (2013-09-05 01:01:05 UTC) #3
siva
PTAL (added generated files to the CL and fixed templateloader for nested if conditions).
7 years, 3 months ago (2013-09-06 23:09:14 UTC) #4
vsm
lgtm
7 years, 3 months ago (2013-09-06 23:10:04 UTC) #5
siva
7 years, 3 months ago (2013-09-06 23:22:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r27270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698