tools/dom/scripts/templateloader.py - Issue 23534050: Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/templateloader.py

Issue 23534050: Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/templateloader.py

===================================================================

--- tools/dom/scripts/templateloader.py (revision 27268)

+++ tools/dom/scripts/templateloader.py (working copy)

@@ -82,7 +82,7 @@

variable = words[1]

if variable in conditions:

condition_stack.append((active, seen_else))

- active = conditions[variable]

+ active = active and conditions[variable]

seen_else = False

else:

error(lineno, "Unknown $if variable '%s'" % variable)

@@ -93,7 +93,8 @@

if seen_else:

raise error(lineno, 'Double $else')

seen_else = True

- active = not active

+ (parentactive, _) = condition_stack[len(condition_stack) - 1]

+ active = not active and parentactive

elif directive == '$endif':

if not condition_stack:

« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | tools/dom/templates/immutable_list_mixin.darttemplate » ('j') | no next file with comments »