Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 23531037: Remove unreachable code in mirrors. (Closed)

Created:
7 years, 3 months ago by Michael Lippautz (Google)
Modified:
7 years, 3 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove unreachable code in mirrors. The only case where we do not set the name in the constructor is for anonymous mixin applications. BUG= R=asiva@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=27390

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M runtime/lib/mirrors.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 2 chunks +2 lines, -11 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Lippautz (Google)
7 years, 3 months ago (2013-09-10 21:50:48 UTC) #1
rmacnak
LGTM with comment https://codereview.chromium.org/23531037/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/23531037/diff/1/runtime/lib/mirrors_impl.dart#newcode463 runtime/lib/mirrors_impl.dart:463: // dynamic, void and the function ...
7 years, 3 months ago (2013-09-10 23:38:51 UTC) #2
Michael Lippautz (Google)
https://codereview.chromium.org/23531037/diff/1/runtime/lib/mirrors_impl.dart File runtime/lib/mirrors_impl.dart (right): https://codereview.chromium.org/23531037/diff/1/runtime/lib/mirrors_impl.dart#newcode463 runtime/lib/mirrors_impl.dart:463: // dynamic, void and the function types have their ...
7 years, 3 months ago (2013-09-11 01:01:15 UTC) #3
siva
lgtm
7 years, 3 months ago (2013-09-11 01:06:52 UTC) #4
Michael Lippautz (Google)
7 years, 3 months ago (2013-09-11 16:10:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698