Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23531037: Remove unreachable code in mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index d7c33faba68168ebaba6ef77417799f9476f318b..acc701d7ed3ee3e7625c2799352a5a5402755c90 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -460,15 +460,9 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl
Symbol _simpleName;
Symbol get simpleName {
- // dynamic, void and the function types have their names set eagerly in the
- // constructor.
+ // All but anonymous mixin applications have their name set at construction.
if(_simpleName == null) {
- var simpleString = _name(_reflectee);
- if (simpleString.contains('&')) {
- _simpleName = this._mixinApplicationName;
- } else {
- _simpleName = _s(simpleString);
- }
+ _simpleName = this._mixinApplicationName;
}
return _simpleName;
}
@@ -718,9 +712,6 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl
int get hashCode => simpleName.hashCode;
- static _name(reflectee)
- native "ClassMirror_name";
-
static _library(reflectee)
native "ClassMirror_library";
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698