test.py: Report info about how long it took until a browser tests started if it times out

test.py: Report info about how long it took until a browser tests started if it times out

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26910

[ahe, 2013-08-30 11:52:27]

LGTM!

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
dart/tools/testing/dart/browser_controller.dart:946: }, onError: (error) {
print(error); });
You're ignoring an error here.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
dart/tools/testing/dart/browser_controller.dart:957: }, onError: (error) {
print(error); });
Ditto.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_runner.dart:1826: var callback = (var output,
delayUntilTestStarted, duration) {
Remove var.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_runner.dart:1835: ". This could be a bug in
test.py! "
Remove space before period.

[kustermann, 2013-08-30 12:54:16]

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
dart/tools/testing/dart/browser_controller.dart:946: }, onError: (error) {
print(error); });
On 2013/08/30 11:52:27, ahe wrote:
> You're ignoring an error here.

That was there before (I just indented it correctly).
The 'print(error)' is not pretty, I changed it now to 'DebugLogger.error()'

Right now, I don't know what we should do in that case, I'll add a TODO.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
dart/tools/testing/dart/browser_controller.dart:957: }, onError: (error) {
print(error); });
On 2013/08/30 11:52:27, ahe wrote:
> Ditto.

Here it's not that important. If we get to this point, then we already know that
the test started (we don't send any content from the browser).

If something went wrong, the test will eventually time out.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_runner.dart:1826: var callback = (var output,
delayUntilTestStarted, duration) {
On 2013/08/30 11:52:27, ahe wrote:
> Remove var.

Done.

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/te...
dart/tools/testing/dart/test_runner.dart:1835: ". This could be a bug in
test.py! "
On 2013/08/30 11:52:27, ahe wrote:
> Remove space before period.

Done.

[kustermann, 2013-08-30 12:55:10]

Thank you.

[kustermann, 2013-08-30 12:55:41]

Committed patchset #3 manually as r26910 (presubmit successful).

[ahe, 2013-08-30 13:09:36]

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
File dart/tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/23522009/diff/3001/dart/tools/testing/dart/br...
dart/tools/testing/dart/browser_controller.dart:957: }, onError: (error) {
print(error); });
On 2013/08/30 12:54:16, kustermann wrote:
> On 2013/08/30 11:52:27, ahe wrote:
> > Ditto.
> 
> Here it's not that important. If we get to this point, then we already know
that
> the test started (we don't send any content from the browser).
> 
> If something went wrong, the test will eventually time out.

In that case, I recommend that you document this in the code.