Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2004)

Unified Diff: dart/tools/testing/dart/test_runner.dart

Issue 23522009: test.py: Report info about how long it took until a browser tests started if it times out (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tools/testing/dart/browser_controller.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_runner.dart
diff --git a/dart/tools/testing/dart/test_runner.dart b/dart/tools/testing/dart/test_runner.dart
index d7bda753465695b637a5bbaa0644120602ae84ed..8058f04b9579a3e36d6309e8d87752fae48d8c59 100644
--- a/dart/tools/testing/dart/test_runner.dart
+++ b/dart/tools/testing/dart/test_runner.dart
@@ -1823,12 +1823,24 @@ class CommandExecutorImpl implements CommandExecutor {
BrowserTestCommand browserCommand, int timeout) {
var completer = new Completer<CommandOutput>();
- var callback = (var output, var duration) {
+ var callback = (output, delayUntilTestStarted, duration) {
+ bool timedOut = output == "TIMEOUT";
+ String stderr = "";
+ if (timedOut) {
+ if (delayUntilTestStarted != null) {
+ stderr = "This test timed out. The delay until the test was actually "
+ "started was: $delayUntilTestStarted.";
+ } else {
+ stderr = "This test has not notified test.py that it started running."
+ " This could be a bug in test.py! "
+ "Please contact ricow/kustermann";
+ }
+ }
var commandOutput = createCommandOutput(browserCommand,
0,
- output == "TIMEOUT",
+ timedOut,
encodeUtf8(output),
- [],
+ encodeUtf8(stderr),
duration,
false);
completer.complete(commandOutput);
« no previous file with comments | « dart/tools/testing/dart/browser_controller.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698