Issue 23514020: Evaluation of expression in context of library top-level

Issue 23514020: Evaluation of expression in context of library top-level (Closed)

Created:
7 years, 3 months ago by hausner

Modified:
7 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Evaluation of expression in context of library top-level Third and final part of expression evaluation in the context of an (object|class|library). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26898

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -3 lines)			Patch
M	runtime/bin/dbg_message.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2	2 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/23514020/diff/9001/runtime/bin/dbg_message.cc File runtime/bin/dbg_message.cc (right): https://codereview.chromium.org/23514020/diff/9001/runtime/bin/dbg_message.cc#newcode650 runtime/bin/dbg_message.cc:650: if (msg_parser.HasParam("libraryId")) { What will happen if ...

7 years, 3 months ago (2013-08-29 23:12:32 UTC) #2

hausner

Committed patchset #3 manually as r26898 (presubmit successful).

7 years, 3 months ago (2013-08-29 23:24:32 UTC) #3

hausner

7 years, 3 months ago (2013-08-29 23:34:46 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23514020/diff/9001/runtime/bin/dbg_message.cc
File runtime/bin/dbg_message.cc (right):

https://codereview.chromium.org/23514020/diff/9001/runtime/bin/dbg_message.cc...
runtime/bin/dbg_message.cc:650: if (msg_parser.HasParam("libraryId")) {
On 2013/08/29 23:12:32, Ivan Posva wrote:
> What will happen if a message has a "libraryId", a "classId" and an
"objectId"?

The protocol does not allow that, but if the client sends a message like this
the libraryId wins since I happen to test for that first here.

Expand Messages | Collapse Messages