Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 23514020: Evaluation of expression in context of library top-level (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger_api_impl.cc
===================================================================
--- runtime/vm/debugger_api_impl.cc (revision 26897)
+++ runtime/vm/debugger_api_impl.cc (working copy)
@@ -514,6 +514,8 @@
return Api::NewHandle(isolate, Instance::Cast(target).Evaluate(expr));
} else if (target.IsClass()) {
return Api::NewHandle(isolate, Class::Cast(target).Evaluate(expr));
+ } else if (target.IsLibrary()) {
+ return Api::NewHandle(isolate, Library::Cast(target).Evaluate(expr));
}
return Api::NewError("%s: unsupported target type", CURRENT_FUNC);
}
@@ -782,6 +784,19 @@
}
+DART_EXPORT Dart_Handle Dart_GetLibraryFromId(intptr_t library_id) {
+ Isolate* isolate = Isolate::Current();
+ ASSERT(isolate != NULL);
+ DARTSCOPE(isolate);
+ const Library& lib = Library::Handle(Library::GetLibrary(library_id));
+ if (lib.IsNull()) {
+ return Api::NewError("%s: %" Pd " is not a valid library id",
+ CURRENT_FUNC, library_id);
+ }
+ return Api::NewHandle(isolate, lib.raw());
+}
+
+
DART_EXPORT Dart_Handle Dart_GetLibraryImports(intptr_t library_id) {
Isolate* isolate = Isolate::Current();
ASSERT(isolate != NULL);
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698