Issue 23507003: Fix piping to a WebSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23507003: Fix piping to a WebSocket (Closed)

Created:
7 years, 3 months ago by Søren Gjesse

Modified:
7 years, 3 months ago

Reviewers:
Lasse Reichstein Nielsen, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix piping to a WebSocket R=lrn@google.com BUG=http://dartbug.com/12923 Committed: https://code.google.com/p/dart/source/detail?r=26991

Patch Set 1 #

Patch Set 2 : Fixed long line #

Patch Set 3 : Addressed review comments #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -1 line)			Patch
	M	sdk/lib/io/websocket_impl.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	A	tests/standalone/io/web_socket_pipe_test.dart	View	1	1 chunk	+73 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #3 manually as r26991 (presubmit successful).

7 years, 3 months ago (2013-09-02 07:33:13 UTC) #3

Bill Hesse

7 years, 3 months ago (2013-09-02 08:38:09 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23507003/diff/7001/tests/standalone/io/web_so...
File tests/standalone/io/web_socket_pipe_test.dart (right):

https://codereview.chromium.org/23507003/diff/7001/tests/standalone/io/web_so...
tests/standalone/io/web_socket_pipe_test.dart:30: Future done;
Indentation, and why not:

(transform ? websocket.transform(new ReverseStringTransformer)
           : websocket)
    .pipe(websocket)
    .then((_) => server.close);

https://codereview.chromium.org/23507003/diff/7001/tests/standalone/io/web_so...
tests/standalone/io/web_socket_pipe_test.dart:53: count++;
Indentation should be 2.

Expand Messages | Collapse Messages