sdk/lib/io/websocket_impl.dart - Issue 23507003: Fix piping to a WebSocket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/websocket_impl.dart

Issue 23507003: Fix piping to a WebSocket (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/websocket_impl.dart

diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart

index f85ddf28829331feb98637ff2befba7a91872e24..3a57c39ce8238cfd948a155ee4ce59889034672a 100644

--- a/sdk/lib/io/websocket_impl.dart

+++ b/sdk/lib/io/websocket_impl.dart

@@ -866,7 +866,8 @@ class _WebSocketImpl extends Stream implements WebSocket {

_outCloseReason = reason;

_writeClosed = true;

}

- return _sink.close();

+ if (!_sink._isBound) _sink.close();

+ return _sink.done;

}

static bool _isReservedStatusCode(int code) {