Do not do global optimizations on fields and parameters when invokeOn is enabled.

Do not do global optimizations on fields and parameters when invokeOn is enabled.

R=ahe@google.com, johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27026

[ngeoffray, 2013-09-02 09:08:01]

PTAL, I added a check whether @MirrorsUsed is there. If it is, then we don't
need to look at enabledInvokeOn.

[ahe, 2013-09-02 09:46:48]

Try this.

https://codereview.chromium.org/23504003/diff/6001/sdk/lib/_internal/lib/js_h...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/23504003/diff/6001/sdk/lib/_internal/lib/js_h...
sdk/lib/_internal/lib/js_helper.dart:178: if (JS('bool', '!#[#]', method,
JS_GET_NAME("REFLECTABLE"))) {
      String reflectableProperty = JS_GET_NAME("REFLECTABLE");
      bool hasReflectableProperty =
          JS('bool', '# in #', reflectableProperty, method);
      if (hasReflectableProperty &&
          JS('bool', '!#[#]', method, reflectableProperty)) {
        throwInvalidReflectionError(memberName);
      }

[ngeoffray, 2013-09-02 09:54:08]

PTAL

https://codereview.chromium.org/23504003/diff/6001/sdk/lib/_internal/lib/js_h...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/23504003/diff/6001/sdk/lib/_internal/lib/js_h...
sdk/lib/_internal/lib/js_helper.dart:178: if (JS('bool', '!#[#]', method,
JS_GET_NAME("REFLECTABLE"))) {
On 2013/09/02 09:46:49, ahe wrote:
>       String reflectableProperty = JS_GET_NAME("REFLECTABLE");
>       bool hasReflectableProperty =
>           JS('bool', '# in #', reflectableProperty, method);
>       if (hasReflectableProperty &&
>           JS('bool', '!#[#]', method, reflectableProperty)) {
>         throwInvalidReflectionError(memberName);
>       }

That worked. Thanks Peter.

[Johnni Winther, 2013-09-02 10:10:55]

lgtm

[ngeoffray, 2013-09-02 13:20:05]

PTAL. I fixed https://code.google.com/p/dart/issues/detail?id=12980 with the
latest patchset.

[ahe, 2013-09-03 06:21:09]

LGTM!

[ahe, 2013-09-03 06:22:16]

Don't forget to test CSP mode.

[ngeoffray, 2013-09-03 07:50:51]

Committed patchset #5 manually as r27026 (presubmit successful).

[ngeoffray, 2013-09-03 07:50:59]

On 2013/09/03 06:22:16, ahe wrote:
> Don't forget to test CSP mode.

Done. Thanks Peter and Johnni.