Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: sdk/lib/_internal/lib/js_helper.dart

Issue 23504003: Do not do global optimizations on fields and parameters when invokeOn is enabled. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/lib/js_helper.dart
===================================================================
--- sdk/lib/_internal/lib/js_helper.dart (revision 27024)
+++ sdk/lib/_internal/lib/js_helper.dart (working copy)
@@ -91,6 +91,10 @@
'which is not included by a @MirrorsUsed annotation');
}
+bool hasReflectableProperty(var jsFunction) {
+ return JS('bool', '# in #', JS_GET_NAME("REFLECTABLE"), jsFunction);
+}
+
class JSInvocationMirror implements Invocation {
static const METHOD = 0;
static const GETTER = 1;
@@ -175,7 +179,7 @@
}
var method = JS('var', '#[#]', receiver, name);
if (JS('String', 'typeof #', method) == 'function') {
- if (JS('bool', '#[#] == false', method, JS_GET_NAME("REFLECTABLE"))) {
+ if (!hasReflectableProperty(method)) {
throwInvalidReflectionError(memberName);
}
return new CachedInvocation(method, isIntercepted, interceptor);
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698