Issue 23498053: Revert "Revert "Dart2js support for custom element lifecycle events""

Issue 23498053: Revert "Revert "Dart2js support for custom element lifecycle events"" (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
ahe, Jennifer Messerly, kustermann

CC:
reviews_dartlang.org, kustermann, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Retry of custom element lifecycle events. First patch is the original, changes were: - Shadow DOM upgrade landed as separate CL - CustomElement polyfill wasn't always firing WebComponentsLoaded event (causing timeouts on FF and IE), fixed polyfill. - Dartium test exclusions were not working BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27841

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+460 lines, -161 lines)			Patch
M	pkg/custom_element/lib/custom-elements.debug.js	View	1	7 chunks	+73 lines, -101 lines	0 comments	Download
M	pkg/custom_element/lib/custom-elements.min.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+35 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View		2 chunks	+1 line, -12 lines	0 comments	Download
M	tests/html/custom/created_callback_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	tests/html/custom/document_register_basic_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download
A	tests/html/custom/entered_left_view_test.dart	View	1	1 chunk	+246 lines, -0 lines	0 comments	Download
A	tests/html/custom/entered_left_view_test.html	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/html/utils.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View		2 chunks	+21 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+16 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #2 manually as r27841 (presubmit successful).

7 years, 3 months ago (2013-09-24 19:14:25 UTC) #3

ahe

https://codereview.chromium.org/23498053/diff/9001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/23498053/diff/9001/tools/testing/dart/test_suite.dart#newcode1005 tools/testing/dart/test_suite.dart:1005: dartWrapperFilename = filePath.toNativePath(); It's really hard for ricow@ and ...

7 years, 2 months ago (2013-09-25 08:37:06 UTC) #4

kustermann

7 years, 2 months ago (2013-09-25 09:28:27 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/23498053/diff/9001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/23498053/diff/9001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1017: compiledDartWrapperFilename =
'$tempDir/$nameNoExt.js';
Recently dart2js has been changed to emit a "test.precompiled.js" in addition to
"test.js". In csp mode the precompiled version has to be used instead of the
normal one, you can see that below in the else branch.

Expand Messages | Collapse Messages