Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 23498053: Revert "Revert "Dart2js support for custom element lifecycle events"" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/templates/html/impl/impl_Element.darttemplate ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 2371140c5b51f52e01270ad5f390506054c72b09..3611976c629fda25824fa1f24f4159118aa4344b 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1001,7 +1001,22 @@ class StandardTestSuite extends TestSuite {
dartWrapperFilename = '${htmlPath}_bootstrap.dart';
compiledDartWrapperFilename = '$dartWrapperFilename.js';
} else {
- htmlPath = customHtmlPath;
+ htmlPath = '$tempDir/test.html';
+ dartWrapperFilename = filePath.toNativePath();
ahe 2013/09/25 08:37:06 It's really hard for ricow@ and kustermann@ to kee
+
+ var htmlContents = customHtml.readAsStringSync();
+ if (compiler == 'none') {
+ htmlContents = htmlContents.replaceAll('%TEST_SCRIPTS%',
+ '<script type="application/dart" '
+ 'src="${_createUrlPathFromFile(filePath)}"></script>\n'
+ '<script type="text/javascript" '
+ 'src="/packages/browser/dart.js"></script>');
+ } else {
+ htmlContents = htmlContents.replaceAll('%TEST_SCRIPTS%',
+ '<script src="$nameNoExt.js"></script>');
+ compiledDartWrapperFilename = '$tempDir/$nameNoExt.js';
kustermann 2013/09/25 09:28:27 Recently dart2js has been changed to emit a "test.
+ }
+ new File(htmlPath).writeAsStringSync(htmlContents);
}
} else {
htmlPath = '$tempDir/test.html';
« no previous file with comments | « tools/dom/templates/html/impl/impl_Element.darttemplate ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698