Re-arrange tests to allow testing generated messages code in dart2js

Re-arrange tests to allow testing generated messages code in dart2js

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26927

[Alan Knight, 2013-08-29 19:29:32]

Catch things like deferred loading not working with dartj2s.

This comments out a bit more deferred-loading related code in the generated
version. And it re-arranges the tests so
  - the generated code is checked-in, instead of being re-created and deleted on
each run. This does require a manual step to re-check it in if code generation
changes, but I can't see a better way. The intermediate files are still deleted.
  - the message writing code writes to a list of strings in memory instead of to
a separate file, so it can be verified without reading/writing files.
   - there's a test that only runs the generated code, doesn't go through the
extraction and translation steps, so it can be run in JS

[Emily Fortuna, 2013-08-29 20:24:14]

lgtm. minor suggestions.

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
File pkg/intl/test/message_extraction/foo_messages_all.dart (right):

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
pkg/intl/test/message_extraction/foo_messages_all.dart:31: // TODO(alanknight):
Restore once Issue 12824 is fixed.
long line here?

Also, should the TODO start one line higher to include the other commented out
line?

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
File pkg/intl/test/message_extraction/foo_messages_de_DE.dart (right):

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
pkg/intl/test/message_extraction/foo_messages_de_DE.dart:4: * messages from the
main program should be duplicated here with the same
can we delete these files from the repo when we get this deferred loading issue
resolved? If so, can you add a TODO (I know you'll have in the script that
generates it, but it will clearly explain our intention with these files.)

[Alan Knight, 2013-08-29 20:39:50]

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
File pkg/intl/test/message_extraction/foo_messages_all.dart (right):

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
pkg/intl/test/message_extraction/foo_messages_all.dart:31: // TODO(alanknight):
Restore once Issue 12824 is fixed.
On 2013/08/29 20:24:15, Emily Fortuna wrote:
> long line here?
> 
> Also, should the TODO start one line higher to include the other commented out
> line?

Odd. Both done.

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
File pkg/intl/test/message_extraction/foo_messages_de_DE.dart (right):

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
pkg/intl/test/message_extraction/foo_messages_de_DE.dart:4: * messages from the
main program should be duplicated here with the same
On 2013/08/29 20:24:15, Emily Fortuna wrote:
> can we delete these files from the repo when we get this deferred loading
issue
> resolved? If so, can you add a TODO (I know you'll have in the script that
> generates it, but it will clearly explain our intention with these files.)

Actually I don't think we want to delete them from the repo once it's fixed,
because we still want something that verifies that this code works on dart2js to
avoid a regression or other dart2js-specific bugs. If we had a way to generate
them from JS code then we could do it, but that would require dart:io working on
d8. And even then, this can be tested in the browser, where we'll never be able
to run the code generation.

[Emily Fortuna, 2013-08-29 21:29:46]

lgtm

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
File pkg/intl/test/message_extraction/foo_messages_de_DE.dart (right):

https://codereview.chromium.org/23484010/diff/12001/pkg/intl/test/message_ext...
pkg/intl/test/message_extraction/foo_messages_de_DE.dart:4: * messages from the
main program should be duplicated here with the same
On 2013/08/29 20:39:50, Alan Knight wrote:
> On 2013/08/29 20:24:15, Emily Fortuna wrote:
> > can we delete these files from the repo when we get this deferred loading
> issue
> > resolved? If so, can you add a TODO (I know you'll have in the script that
> > generates it, but it will clearly explain our intention with these files.)
> 
> Actually I don't think we want to delete them from the repo once it's fixed,
> because we still want something that verifies that this code works on dart2js
to
> avoid a regression or other dart2js-specific bugs. If we had a way to generate
> them from JS code then we could do it, but that would require dart:io working
on
> d8. And even then, this can be tested in the browser, where we'll never be
able
> to run the code generation.

sgtm.

[Alan Knight, 2013-08-30 17:03:46]

Committed patchset #5 manually as r26927 (presubmit successful).