Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pkg/intl/lib/generate_localized.dart

Issue 23484010: Re-arrange tests to allow testing generated messages code in dart2js (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Regenerated code Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/intl/test/message_extraction/foo_messages_all.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/lib/generate_localized.dart
diff --git a/pkg/intl/lib/generate_localized.dart b/pkg/intl/lib/generate_localized.dart
index f72af3fb0a0255b5a781b51dc28c72b805b44055..285e05e710db5ca5cb10193fd3437250b642471b 100644
--- a/pkg/intl/lib/generate_localized.dart
+++ b/pkg/intl/lib/generate_localized.dart
@@ -165,15 +165,16 @@ String generateMainImportFile() {
output.write("import '$file' as ${_libraryName(locale)};\n");
}
output.write("\n");
- for (var locale in allLocales) {
- output.write("const ${_deferredName(locale)} = const DeferredLibrary");
- output.write("('${_libraryName(locale)}');\n");
- }
- output.write("\nconst deferredLibraries = const {\n");
- for (var locale in allLocales) {
- output.write(" '$locale' : ${_deferredName(locale)},\n");
- }
- output.write("};\n");
+ // Issue 12824
+ //for (var locale in allLocales) {
+ // output.write("const ${_deferredName(locale)} = const DeferredLibrary");
+ // output.write("('${_libraryName(locale)}');\n");
+ //}
+ //output.write("\nconst deferredLibraries = const {\n");
+ //for (var locale in allLocales) {
+ // output.write(" '$locale' : ${_deferredName(locale)},\n");
+ //}
+ //output.write("};\n");
output.write(
"\nMessageLookupByLibrary _findExact(localeName) {\n"
" switch (localeName) {\n");
@@ -217,8 +218,8 @@ const closing = """
Future initializeMessages(String localeName) {
initializeInternalMessageLookup(() => new CompositeMessageLookup());
messageLookup.addLocale(localeName, _findGeneratedMessagesFor);
- var lib = deferredLibraries[localeName];
- // TODO(alanknight): Restore once Issue 12824 is fixed.
+ // TODO(alanknight): Restore once Issue 12824 is fixed.
+ // var lib = deferredLibraries[localeName];
// return lib == null ? new Future.value(false) : lib.load();
return new Future.value(true);
}
« no previous file with comments | « no previous file | pkg/intl/test/message_extraction/foo_messages_all.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698