Evaluates arguments before throwing a NoSuchMethodError in constructor

Evaluates arguments before throwing a NoSuchMethodError in constructor
calls and static function calls.

Fixes issue 12820.

R=regis@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26827

[regis, 2013-08-28 21:10:54]

LGTM with comments.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/ast.h
File runtime/vm/ast.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/ast.h#newcode225
runtime/vm/ast.h:225: }
This could fit on one line.
names() and set_names(...) above too.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3572: ArgumentListNode* actuals,
function_arguments

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.h:362: ArgumentListNode* actuals,
If we emulate the naming convention used by BuildStaticNoSuchMethodCall above,
'actuals' should be called 'function_arguments'.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.h:369: token_pos, function_class, function_name,
NULL, invocation_type);
Overriding is not encouraged. Why not make it clear by forcing the caller to
pass NULL?

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:7212: ArgumentListNode* actuals,
function_arguments

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h#newcod...
runtime/vm/parser.h:639: ArgumentListNode* actuals,
function_arguments

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h#newcod...
runtime/vm/parser.h:649: }
No overriding, please.

[srdjan, 2013-08-28 21:43:14]

lgtm

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3615: }
The code above could be:
ConstantInstr* cinstr = new ConstantInstr((actuals == NULL) ?
Array::ZoneHandle() : actuals->names())
Value* argument_names_value = Bind(cinstr);
arguments->Add(PushArgument(argument_names_value);

[regis, 2013-08-28 21:49:39]

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h#newcod...
runtime/vm/parser.h:649: }
On 2013/08/28 21:10:54, regis wrote:
> No overriding, please.

As Srdjan rightfully pointed out, I meant no overloading, please.

[zra, 2013-08-28 22:47:00]

Thanks!

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/ast.h
File runtime/vm/ast.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/ast.h#newcode225
runtime/vm/ast.h:225: }
On 2013/08/28 21:10:54, regis wrote:
> This could fit on one line.
> names() and set_names(...) above too.

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3572: ArgumentListNode* actuals,
On 2013/08/28 21:10:54, regis wrote:
> function_arguments

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:3615: }
On 2013/08/28 21:43:15, srdjan wrote:
> The code above could be:
> ConstantInstr* cinstr = new ConstantInstr((actuals == NULL) ?
> Array::ZoneHandle() : actuals->names())
> Value* argument_names_value = Bind(cinstr);
> arguments->Add(PushArgument(argument_names_value);

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.h:362: ArgumentListNode* actuals,
On 2013/08/28 21:10:54, regis wrote:
> If we emulate the naming convention used by BuildStaticNoSuchMethodCall above,
> 'actuals' should be called 'function_arguments'.

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.h:369: token_pos, function_class, function_name,
NULL, invocation_type);
On 2013/08/28 21:10:54, regis wrote:
> Overriding is not encouraged. Why not make it clear by forcing the caller to
> pass NULL?

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:7212: ArgumentListNode* actuals,
On 2013/08/28 21:10:54, regis wrote:
> function_arguments

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h
File runtime/vm/parser.h (right):

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h#newcod...
runtime/vm/parser.h:639: ArgumentListNode* actuals,
On 2013/08/28 21:10:54, regis wrote:
> function_arguments

Done.

https://codereview.chromium.org/23482004/diff/8001/runtime/vm/parser.h#newcod...
runtime/vm/parser.h:649: }
On 2013/08/28 21:10:54, regis wrote:
> No overriding, please.

Done.

[zra, 2013-08-28 23:40:07]

Committed patchset #3 manually as r26827 (presubmit successful).