Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail.

Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27542

[siva, 2013-09-17 00:06:24]

LGTM once comments are addressed.

https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc
File runtime/lib/identical.cc (right):

https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc#n...
runtime/lib/identical.cc:26: }
This method should be moved into 'class Instance' in object.h
and it should return 'bool' (see comment in next file).

https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc#n...
runtime/lib/identical.cc:31: return Identical(a, b);
return a.IsIdentical(b) ? Bool::True().raw() : Bool::False().raw();

https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:10: #include "lib/identical.h"
I don't think we want to include stuff from "lib/..." here.

You should add Identical to class Instance in "object.h" as
IsIdentical or something like that which returns 'bool' and the
code below would be:

return Instance::Cast(object1).IsIdentical(Instance::Cast(object2));

https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:512: return object1.raw() == object2.raw();
Wouldn't it be more efficient to first compare the raw pointers and
if they are not equal then do the Identical stuff, i.e
{
  NoGCScope ngc;
  if (Api::UnwrapHandle(obj1) == Api::UnwrapHandle(obj2)) {
    return true;
  }
}
....
....
the Identical stuff
....
...

[rmacnak, 2013-09-17 01:14:05]

On 2013/09/17 00:06:24, siva wrote:
> LGTM once comments are addressed.
> 
> https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc
> File runtime/lib/identical.cc (right):
> 
>
https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc#n...
> runtime/lib/identical.cc:26: }
> This method should be moved into 'class Instance' in object.h
> and it should return 'bool' (see comment in next file).
> 
>
https://codereview.chromium.org/23464073/diff/3001/runtime/lib/identical.cc#n...
> runtime/lib/identical.cc:31: return Identical(a, b);
> return a.IsIdentical(b) ? Bool::True().raw() : Bool::False().raw();
> 
> https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.cc
> File runtime/vm/dart_api_impl.cc (right):
> 
>
https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.c...
> runtime/vm/dart_api_impl.cc:10: #include "lib/identical.h"
> I don't think we want to include stuff from "lib/..." here.
> 
> You should add Identical to class Instance in "object.h" as
> IsIdentical or something like that which returns 'bool' and the
> code below would be:
> 
> return Instance::Cast(object1).IsIdentical(Instance::Cast(object2));
> 
>
https://codereview.chromium.org/23464073/diff/3001/runtime/vm/dart_api_impl.c...
> runtime/vm/dart_api_impl.cc:512: return object1.raw() == object2.raw();
> Wouldn't it be more efficient to first compare the raw pointers and
> if they are not equal then do the Identical stuff, i.e
> {
>   NoGCScope ngc;
>   if (Api::UnwrapHandle(obj1) == Api::UnwrapHandle(obj2)) {
>     return true;
>   }
> }
> ....
> ....
> the Identical stuff
> ....
> ...

Moved implementation to dart::Instance and made true identity a fast path.

[rmacnak, 2013-09-17 01:30:36]

Committed patchset #3 manually as r27542 (presubmit successful).