Make Dart_IdentityEqual live up to its spec and not leak boxing implementation detail.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
+#include "lib/identical.h"

[siva, 2013/09/17 00:06:24]

I don't think we want to include stuff from "lib/..." here.

You should add Identical to class Instance in "object.h" as
IsIdentical or something like that which returns 'bool' and the
code below would be:

return Instance::Cast(object1).IsIdentical(Instance::Cast(object2));

 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
 #include "vm/debuginfo.h"
 #include "vm/exceptions.h"
@@ skipping 470 matching lines @@
     CHECK_CALLBACK_STATE(isolate);
     // This is a VM internal object. Call the C++ method of printing.
     return Api::NewHandle(isolate, String::New(obj.ToCString()));
   }
 }
 
 
 DART_EXPORT bool Dart_IdentityEquals(Dart_Handle obj1, Dart_Handle obj2) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
+
+  const Object& object1 = Object::Handle(isolate, Api::UnwrapHandle(obj1));
+  const Object& object2 = Object::Handle(isolate, Api::UnwrapHandle(obj2));
+  if (object1.IsInstance() && object2.IsInstance()) {
+    const Bool& result =
+        Bool::Handle(isolate, Identical(Instance::Cast(object1),
+                                        Instance::Cast(object2)));
+    return result.value();
+  }
+
   NoGCScope ngc;
-  return Api::UnwrapHandle(obj1) == Api::UnwrapHandle(obj2);
+  return object1.raw() == object2.raw();

[siva, 2013/09/17 00:06:24]

Wouldn't it be more efficient to first compare the raw pointers and
if they are not equal then do the Identical stuff, i.e
{
  NoGCScope ngc;
  if (Api::UnwrapHandle(obj1) == Api::UnwrapHandle(obj2)) {
    return true;
  }
}
....
....
the Identical stuff
....
...

 }
 
 
 DART_EXPORT Dart_Handle Dart_HandleFromPersistent(
     Dart_PersistentHandle object) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   ASSERT(state->IsValidPersistentHandle(object));
@@ skipping 3825 matching lines @@
   }
   {
     NoGCScope no_gc;
     RawObject* raw_obj = obj.raw();
     isolate->heap()->SetPeer(raw_obj, peer);
   }
   return Api::Success();
 }
 
 }  // namespace dart