Issue 23461018: Fixing Indexed DB from latest Blink roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23461018: Fixing Indexed DB from latest Blink roll (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
vsm, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing Indexed DB from latest Blink roll Primarily changes to support syntax from: https://codereview.chromium.org//23788007 https://codereview.chromium.org//23523008 BUG=12948 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=27084

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -15 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	4 chunks	+14 lines, -4 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	tools/dom/idl/dart/dart.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBIndex.darttemplate	View	2 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/23461018/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/23461018/diff/1/tests/html/html.status#newcode6 tests/html/html.status:6: #indexeddb_3_test: Skip # Issue 12948 remove rather than ...

7 years, 3 months ago (2013-09-03 20:17:25 UTC) #2

blois

7 years, 3 months ago (2013-09-03 23:35:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27084 (presubmit successful).

Expand Messages | Collapse Messages