Issue 23788007: Remove invalid calls to the _count method. This is a short term fix to make the build green. Blois…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23788007: Remove invalid calls to the _count method. This is a short term fix to make the build green. Blois… (Closed)

Created:
7 years, 3 months ago by Jacob

Modified:
7 years, 3 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove invalid calls to the _count method. This is a short term fix to make the build green. Blois will be submitting the correct fix. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26956

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -54 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	3 chunks	+3 lines, -18 lines	1 comment	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	3 chunks	+3 lines, -18 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBIndex.darttemplate	View	3 chunks	+3 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/23788007/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right): https://codereview.chromium.org/23788007/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#newcode534 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:534: var request = _count(key_OR_range); http://www.w3.org/TR/IndexedDB/#widl-IDBObjectStore-count-IDBRequest-any-key Count is not nullable ...

7 years, 3 months ago (2013-08-30 22:57:37 UTC) #2

Jacob

7 years, 3 months ago (2013-08-30 23:01:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26956 (presubmit successful).

Expand Messages | Collapse Messages