Issue 23456028: report error message when import urls are broken.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23456028: report error message when import urls are broken. (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

report error message when import urls are broken. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27495

Patch Set 4 : #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -16 lines)			Patch
M	pkg/polymer/lib/src/build/common.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/src/build/linter.dart	View	1 2 3	1 chunk	+27 lines, -16 lines	2 comments	Download
M	pkg/polymer/test/build/linter_test.dart	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/23456028/diff/7001/pkg/polymer/lib/src/build/linter.dart File pkg/polymer/lib/src/build/linter.dart (right): https://codereview.chromium.org/23456028/diff/7001/pkg/polymer/lib/src/build/linter.dart#newcode96 pkg/polymer/lib/src/build/linter.dart:96: '"${id.package}".', span); +2 indent

7 years, 3 months ago (2013-09-13 18:12:40 UTC) #2

Siggi Cherem (dart-lang)

Committed patchset #4 manually as r27495 (presubmit successful).

7 years, 3 months ago (2013-09-13 18:19:55 UTC) #3

Siggi Cherem (dart-lang)

7 years, 3 months ago (2013-09-13 18:20:16 UTC) #4

Message was sent while issue was closed.

thx

https://codereview.chromium.org/23456028/diff/7001/pkg/polymer/lib/src/build/...
File pkg/polymer/lib/src/build/linter.dart (right):

https://codereview.chromium.org/23456028/diff/7001/pkg/polymer/lib/src/build/...
pkg/polymer/lib/src/build/linter.dart:96: '"${id.package}".', span);
On 2013/09/13 18:12:40, John Messerly wrote:
> +2 indent

Done.

Expand Messages | Collapse Messages

Issue 23456028: report error message when import urls are broken. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages