Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Side by Side Diff: pkg/polymer/test/build/linter_test.dart

Issue 23456028: report error message when import urls are broken. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library polymer.test.linter_test; 5 library polymer.test.linter_test;
6 6
7 import 'package:polymer/src/build/common.dart'; 7 import 'package:polymer/src/build/common.dart';
8 import 'package:polymer/src/build/linter.dart'; 8 import 'package:polymer/src/build/linter.dart';
9 import 'package:source_maps/span.dart'; 9 import 'package:source_maps/span.dart';
10 import 'package:unittest/compact_vm_config.dart'; 10 import 'package:unittest/compact_vm_config.dart';
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 <polymer-element name="x-a"></polymer-element> 59 <polymer-element name="x-a"></polymer-element>
60 </html>'''.replaceAll(' ', ''), 60 </html>'''.replaceAll(' ', ''),
61 }, { 61 }, {
62 'a|lib/test.html.messages': 62 'a|lib/test.html.messages':
63 'warning: duplicate definition for custom tag "x-a". ' 63 'warning: duplicate definition for custom tag "x-a". '
64 '(lib/b.html 1 0)\n' 64 '(lib/b.html 1 0)\n'
65 'warning: duplicate definition for custom tag "x-a" ' 65 'warning: duplicate definition for custom tag "x-a" '
66 '(second definition). (lib/test.html 2 0)' 66 '(second definition). (lib/test.html 2 0)'
67 }); 67 });
68 68
69 _testLinter('non existing file', {
70 'a|lib/test.html': '''<html>
71 <link rel="import" href="b.html">
72 <polymer-element name="x-a"></polymer-element>
73 </html>'''.replaceAll(' ', ''),
74 }, {
75 'a|lib/test.html.messages':
76 'error: couldn\'t find imported asset "lib/b.html" in package '
77 '"a". (lib/test.html 1 0)'
78 });
79
69 _testLinter('other package', { 80 _testLinter('other package', {
70 'b|lib/b.html': '''<html> 81 'b|lib/b.html': '''<html>
71 <polymer-element name="x-a"></polymer-element> 82 <polymer-element name="x-a"></polymer-element>
72 </html>'''.replaceAll(' ', ''), 83 </html>'''.replaceAll(' ', ''),
73 'a|lib/test.html': '''<html> 84 'a|lib/test.html': '''<html>
74 <link rel="import" href="packages/b/b.html"> 85 <link rel="import" href="packages/b/b.html">
75 <polymer-element name="x-a"></polymer-element> 86 <polymer-element name="x-a"></polymer-element>
76 </html>'''.replaceAll(' ', ''), 87 </html>'''.replaceAll(' ', ''),
77 }, { 88 }, {
78 'a|lib/test.html.messages': 89 'a|lib/test.html.messages':
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 424
414 425
415 _testFormatter(String kind, String message, Span span) { 426 _testFormatter(String kind, String message, Span span) {
416 var formattedMessage = '$kind: $message'; 427 var formattedMessage = '$kind: $message';
417 if (span != null) { 428 if (span != null) {
418 formattedMessage = '$formattedMessage ' 429 formattedMessage = '$formattedMessage '
419 '(${span.sourceUrl} ${span.start.line} ${span.start.column})'; 430 '(${span.sourceUrl} ${span.start.line} ${span.start.column})';
420 } 431 }
421 return formattedMessage; 432 return formattedMessage;
422 } 433 }
OLDNEW
« pkg/polymer/lib/src/build/linter.dart ('K') | « pkg/polymer/lib/src/build/linter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698