Check cycles in redirecting factories.

Check cycles in redirecting factories.

BUG=dartubg.com/10959
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27645

[ngeoffray, 2013-09-18 11:19:23]

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1286: :
defaultImplementation;
This looks weird. Depending on the current stage of the compiler the element
model could return you something different? Can't you just return
internalRedirectionTarget and have the callers deal if it's null?

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2689: // the
constructors again and set their [redirectionTarget].
Why do you need to do this for all seen targets? Won't they be able to do that
for just themselves when their post process action is being executed?

[karlklose, 2013-09-18 12:30:38]

PTAL.

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1286: :
defaultImplementation;
Actually I can decide which of them to return independent of their value.

internalRedirectionTarget still changes during post-processing, but the getter
is only called in the backend.

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/23452038/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2689: // the
constructors again and set their [redirectionTarget].
It is an optimization to not do the lookup again if two chains of redirections
share a path.

[ngeoffray, 2013-09-18 12:52:07]

LGTM

https://codereview.chromium.org/23452038/diff/10001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right):

https://codereview.chromium.org/23452038/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1296: :
defaultImplementation;
Please return null instead of defaultImplementation.

https://codereview.chromium.org/23452038/diff/10001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/23452038/diff/10001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2692: // the
constructors again and set their [redirectionTarget].
Please add a comment that this is an optimization to avoid other post process
action to do the same loop above again.

[karlklose, 2013-09-19 08:17:10]

Committed patchset #4 manually as r27645 (presubmit successful).