Check cycles in redirecting factories.

sdk/lib/_internal/compiler/implementation/warnings.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 const DONT_KNOW_HOW_TO_FIX = "";
 
 /**
  * The messages in this file should meet the following guide lines:
@@ skipping 151 matching lines @@
       'Warning: Not all paths lead to a return or throw statement.');
 
   static const DualKind CANNOT_RESOLVE = const DualKind(
       error: const MessageKind('Error: Cannot resolve "#{name}".'),
       warning: const MessageKind('Warning: Cannot resolve "#{name}".'));
 
   static const MessageKind CANNOT_RESOLVE_CONSTRUCTOR = const MessageKind(
       'Error: Cannot resolve constructor "#{constructorName}".');
 
   static const MessageKind CANNOT_RESOLVE_CONSTRUCTOR_FOR_IMPLICIT =
-      const MessageKind(
-          'Error: cannot resolve constructor "#{constructorName}" for implicit'
-          'super call.');
+      const MessageKind('Error: cannot resolve constructor "#{constructorName}"'
+          ' for implicit super call.',
+      howToFix: 'Try explicitly invoking a constructor of the super class',
+      examples: const ["""
+class A {
+  A.foo() {}
+}
+class B etxends A {}
+main() => new B();
+"""]);
 
   static const MessageKind INVALID_UNNAMED_CONSTRUCTOR_NAME = const MessageKind(
       'Error: Unnamed constructor name must be "#{name}".');
 
   static const MessageKind INVALID_CONSTRUCTOR_NAME = const MessageKind(
       'Error: Constructor name must start with "#{name}".');
 
   static const DualKind CANNOT_RESOLVE_TYPE = const DualKind(
       error: const MessageKind('Error: Cannot resolve type "#{typeName}".'),
       warning: const MessageKind(
@@ skipping 74 matching lines @@
 
   static const DualKind CANNOT_FIND_CONSTRUCTOR = const DualKind(
       error: const MessageKind(
           'Error: Cannot find constructor "#{constructorName}".'),
       warning: const MessageKind(
           'Warning: Cannot find constructor "#{constructorName}".'));
 
   static const MessageKind CYCLIC_CLASS_HIERARCHY = const MessageKind(
       'Error: "#{className}" creates a cycle in the class hierarchy.');
 
+  static const MessageKind CYCLIC_REDIRECTING_FACTORY = const MessageKind(
+      'Error: Redirecting factory leads to a cyclic redirection.');
+
   static const MessageKind INVALID_RECEIVER_IN_INITIALIZER = const MessageKind(
       'Error: Field initializer expected.');
 
   static const MessageKind NO_SUPER_IN_STATIC = const MessageKind(
       'Error: "super" is only available in instance methods.');
 
   static const MessageKind DUPLICATE_INITIALIZER = const MessageKind(
       'Error: Field "#{fieldName}" is initialized more than once.');
 
   static const MessageKind ALREADY_INITIALIZED = const MessageKind(
@@ skipping 959 matching lines @@
 
 class CompileTimeConstantError extends Diagnostic {
   CompileTimeConstantError(MessageKind kind, Map arguments, bool terse)
     : super(kind, arguments, terse);
 }
 
 class CompilationError extends Diagnostic {
   CompilationError(MessageKind kind, Map arguments, bool terse)
     : super(kind, arguments, terse);
 }