Implement redirecting factories in mirrors.

Implement redirecting factories in mirrors.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27561

[karlklose, 2013-09-17 09:12:51]

DBC

https://codereview.chromium.org/23450040/diff/1001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/23450040/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4185: if
(node.isRedirectingFactoryBody) {
Please add a TODO for me that this implementation does not actually work with
type arguments. It is OK now, but if we are changing it to actually be inlined,
we'll have to fix it.

[ahe, 2013-09-17 10:06:02]

LGTM!

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/mirrors_...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/mirrors_...
tests/lib/mirrors/mirrors_test.dart:224: if (isDart2js) return;
Can you remove this one as well?

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/redirect...
File tests/lib/mirrors/redirecting_factory_test.dart (right):

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/redirect...
tests/lib/mirrors/redirecting_factory_test.dart:60: // Currently not implemented
in dart2js.
bool isDart2js = false;
isDart2js = true; /// 01: ok
if (isDart2js) return;

[ngeoffray, 2013-09-17 12:02:24]

Thanks Karl and Peter.

https://codereview.chromium.org/23450040/diff/1001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/23450040/diff/1001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:4185: if
(node.isRedirectingFactoryBody) {
On 2013/09/17 09:12:51, karlklose wrote:
> Please add a TODO for me that this implementation does not actually work with
> type arguments. It is OK now, but if we are changing it to actually be
inlined,
> we'll have to fix it.

I've implemented it instead.

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/mirrors_...
File tests/lib/mirrors/mirrors_test.dart (right):

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/mirrors_...
tests/lib/mirrors/mirrors_test.dart:224: if (isDart2js) return;
On 2013/09/17 10:06:03, ahe wrote:
> Can you remove this one as well?

Done.

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/redirect...
File tests/lib/mirrors/redirecting_factory_test.dart (right):

https://codereview.chromium.org/23450040/diff/5001/tests/lib/mirrors/redirect...
tests/lib/mirrors/redirecting_factory_test.dart:60: // Currently not implemented
in dart2js.
On 2013/09/17 10:06:03, ahe wrote:
> bool isDart2js = false;
> isDart2js = true; /// 01: ok
> if (isDart2js) return;

Done.

[ngeoffray, 2013-09-17 12:05:47]

Committed patchset #5 manually as r27561 (presubmit successful).